Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add pvc for xline data dir #48

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Phoenix500526
Copy link
Contributor

@Phoenix500526 Phoenix500526 commented Dec 23, 2023

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    implement the pvc feature and auth feature

  • what changes does this pull request make?

  1. implement the pvc and auth feature
  2. fix some validation failed issues
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@Phoenix500526 Phoenix500526 force-pushed the feat/local-pvc branch 5 times, most recently from e15b220 to df9ba3a Compare January 16, 2024 11:38
@Phoenix500526 Phoenix500526 force-pushed the feat/local-pvc branch 4 times, most recently from a706e63 to 37046a1 Compare February 1, 2024 06:14
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Comparison is base (9721330) 18.95% compared to head (5ba4d5e) 16.31%.
Report is 2 commits behind head on main.

Files Patch % Lines
internal/transformer/xlinecluster_resource.go 0.00% 53 Missing ⚠️
api/v1alpha1/zz_generated.deepcopy.go 0.00% 40 Missing ⚠️
internal/util/kubeutil.go 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   18.95%   16.31%   -2.64%     
==========================================
  Files          11       11              
  Lines         575      668      +93     
==========================================
  Hits          109      109              
- Misses        463      556      +93     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Phoenix500526 Phoenix500526 force-pushed the feat/local-pvc branch 5 times, most recently from 9146543 to b832b06 Compare February 5, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant