-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/secret #44
Closed
Closed
Feat/secret #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LingKa28
previously approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Phoenix500526
force-pushed
the
feat/secret
branch
2 times, most recently
from
January 15, 2024 07:48
a12fe7d
to
5b82415
Compare
Phoenix500526
force-pushed
the
feat/secret
branch
2 times, most recently
from
February 5, 2024 00:33
d1043b9
to
2228aa3
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
- Coverage 18.95% 16.97% -1.98%
==========================================
Files 11 11
Lines 575 642 +67
==========================================
Hits 109 109
- Misses 463 530 +67
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Phoenix500526
force-pushed
the
feat/secret
branch
from
February 5, 2024 01:48
2228aa3
to
f456541
Compare
themanforfree
previously approved these changes
Feb 5, 2024
Phoenix500526
force-pushed
the
feat/secret
branch
3 times, most recently
from
February 5, 2024 07:12
2464be5
to
36cf8d4
Compare
Signed-off-by: Phoeniix Zhao <[email protected]>
Phoenix500526
force-pushed
the
feat/secret
branch
from
February 5, 2024 07:43
36cf8d4
to
0b90f1d
Compare
Signed-off-by: Phoeniix Zhao <[email protected]>
Signed-off-by: Phoeniix Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
use secret to specify auth key pair
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)