Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/secret #44

Closed
wants to merge 3 commits into from
Closed

Conversation

Phoenix500526
Copy link
Contributor

@Phoenix500526 Phoenix500526 commented Dec 20, 2023

Please briefly answer these questions:
use secret to specify auth key pair

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

LingKa28
LingKa28 previously approved these changes Jan 2, 2024
Copy link
Collaborator

@LingKa28 LingKa28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Phoenix500526 Phoenix500526 force-pushed the feat/secret branch 2 times, most recently from a12fe7d to 5b82415 Compare January 15, 2024 07:48
@Phoenix500526 Phoenix500526 force-pushed the feat/secret branch 2 times, most recently from d1043b9 to 2228aa3 Compare February 5, 2024 00:33
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (9721330) 18.95% compared to head (0b90f1d) 16.97%.
Report is 2 commits behind head on main.

Files Patch % Lines
internal/transformer/xlinecluster_resource.go 0.00% 42 Missing ⚠️
api/v1alpha1/zz_generated.deepcopy.go 0.00% 34 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   18.95%   16.97%   -1.98%     
==========================================
  Files          11       11              
  Lines         575      642      +67     
==========================================
  Hits          109      109              
- Misses        463      530      +67     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

themanforfree
themanforfree previously approved these changes Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants