Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/Refactor controller logic #27

Merged
merged 10 commits into from
Oct 25, 2023
Merged

Conversation

iGxnon
Copy link
Collaborator

@iGxnon iGxnon commented Aug 18, 2023

Base on #19

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    This PR refactor controller into three parts: Extractor, Factory, Manager.
    Introducing these components benefits us by segregating the logic of the controller, facilitating unit testing, and preparing for the eventual replacement of the StatefulSet controller.

  • what changes does this pull request make?

    As above.

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

    No

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Attention: 410 lines in your changes are missing coverage. Please review.

Comparison is base (c50a845) 18.94% compared to head (68810f8) 40.68%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #27       +/-   ##
===========================================
+ Coverage   18.94%   40.68%   +21.73%     
===========================================
  Files          23       21        -2     
  Lines        1768     1728       -40     
  Branches     1768     1728       -40     
===========================================
+ Hits          335      703      +368     
+ Misses       1427     1012      -415     
- Partials        6       13        +7     
Files Coverage Δ
operator-api/src/lib.rs 73.33% <100.00%> (ø)
operator-k8s/src/lib.rs 100.00% <ø> (ø)
sidecar/src/lib.rs 100.00% <ø> (ø)
sidecar/src/routers.rs 0.00% <ø> (ø)
sidecar/src/xline.rs 0.00% <ø> (ø)
operator-k8s/src/config.rs 0.00% <0.00%> (ø)
operator-k8s/src/crd/v1alpha1/cluster.rs 92.92% <80.00%> (-0.69%) ⬇️
sidecar/src/utils.rs 62.16% <71.42%> (ø)
operator-k8s/src/monitor.rs 50.72% <28.57%> (ø)
operator-k8s/src/crd/version.rs 74.35% <0.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iGxnon iGxnon force-pushed the refactor/controller branch from af1f2c2 to 252000b Compare August 18, 2023 14:06
@iGxnon iGxnon force-pushed the refactor/controller branch 3 times, most recently from 9c21ed6 to db5fa90 Compare September 7, 2023 13:46
@iGxnon iGxnon linked an issue Sep 10, 2023 that may be closed by this pull request
1 task
@iGxnon iGxnon force-pushed the refactor/controller branch 5 times, most recently from a8e8eda to 93cd802 Compare September 11, 2023 14:35
@iGxnon iGxnon force-pushed the refactor/controller branch from 93cd802 to d8c748b Compare October 12, 2023 02:22
@iGxnon iGxnon added this to the v0.2.0 milestone Oct 16, 2023
@iGxnon iGxnon force-pushed the refactor/controller branch from d8c748b to bd9d2f2 Compare October 17, 2023 07:36
@iGxnon iGxnon marked this pull request as ready for review October 17, 2023 07:36
@iGxnon iGxnon mentioned this pull request Oct 22, 2023
operator-k8s/src/manager/cluster.rs Outdated Show resolved Hide resolved
operator-k8s/src/manager/cluster.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 0627722 into xline-kv:main Oct 25, 2023
16 checks passed
@iGxnon iGxnon deleted the refactor/controller branch October 25, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: CRD Versions Management
3 participants