-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/Refactor controller logic #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
===========================================
+ Coverage 18.94% 40.68% +21.73%
===========================================
Files 23 21 -2
Lines 1768 1728 -40
Branches 1768 1728 -40
===========================================
+ Hits 335 703 +368
+ Misses 1427 1012 -415
- Partials 6 13 +7
☔ View full report in Codecov by Sentry. |
iGxnon
force-pushed
the
refactor/controller
branch
from
August 18, 2023 14:06
af1f2c2
to
252000b
Compare
iGxnon
force-pushed
the
refactor/controller
branch
3 times, most recently
from
September 7, 2023 13:46
9c21ed6
to
db5fa90
Compare
1 task
iGxnon
force-pushed
the
refactor/controller
branch
5 times, most recently
from
September 11, 2023 14:35
a8e8eda
to
93cd802
Compare
iGxnon
force-pushed
the
refactor/controller
branch
from
October 12, 2023 02:22
93cd802
to
d8c748b
Compare
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
iGxnon
force-pushed
the
refactor/controller
branch
from
October 17, 2023 07:36
d8c748b
to
bd9d2f2
Compare
Signed-off-by: iGxnon <[email protected]>
Closed
Signed-off-by: iGxnon <[email protected]>
Signed-off-by: iGxnon <[email protected]>
Phoenix500526
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bsbds
reviewed
Oct 25, 2023
bsbds
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base on #19
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
This PR refactor controller into three parts:
Extractor
,Factory
,Manager
.Introducing these components benefits us by segregating the logic of the controller, facilitating unit testing, and preparing for the eventual replacement of the StatefulSet controller.
what changes does this pull request make?
As above.
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
No