-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: curp client propose #975
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsbds
force-pushed
the
refactor-propose
branch
4 times, most recently
from
September 2, 2024 04:13
845abc1
to
d49dd01
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #975 +/- ##
==========================================
- Coverage 75.55% 75.23% -0.33%
==========================================
Files 180 190 +10
Lines 26938 28479 +1541
Branches 26938 28479 +1541
==========================================
+ Hits 20353 21426 +1073
- Misses 5366 5756 +390
- Partials 1219 1297 +78 ☔ View full report in Codecov by Sentry. |
bsbds
force-pushed
the
refactor-propose
branch
from
September 2, 2024 04:38
d49dd01
to
aa8bee0
Compare
lxl66566
reviewed
Sep 23, 2024
@bsbds Your PR is in conflict and cannot be merged. |
bsbds
force-pushed
the
refactor-propose
branch
from
September 23, 2024 02:47
01118fe
to
f33cdd5
Compare
@bsbds Convert your pr to draft since CI failed |
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
bsbds
force-pushed
the
refactor-propose
branch
from
September 23, 2024 02:56
f33cdd5
to
7cfccb6
Compare
lxl66566
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several changes:
propose_impl
This is done by simultaneously waitting for the
record
request to the cluster and the message from the leader gRPC stream.Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)