fix: remove counter to keep aligned with early return in fast path #859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Update testing logic to keep aligned with early return in fast path.
Since we can return early in fast path when the number of conlicts is so large that we cannot reach SuperQuorum.
So we DO NOT NEED to force all the 5 servers to handle the propose.
related issue : [Bug]: test_unary_propose_fast_path_fallback_slow_path will randomly failed #840
what changes does this pull request make?
Remove the counter, and the rest part works fine (Successfully fallback to slow path) .
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)