Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return early in fast_round if the recover_quorum condition is not met #835

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

poltao
Copy link
Contributor

@poltao poltao commented Jun 3, 2024

what problem are you trying to solve?

close #825

Return early in fast_round if the KeyConflicts number is greater than or equal to the recovery quorum.

@mergify mergify bot requested a review from a team June 3, 2024 09:28
@poltao poltao force-pushed the improve-fast-round branch from 873dbb6 to 23bce7d Compare June 3, 2024 09:32
Copy link

mergify bot commented Jun 3, 2024

@realtaobo Convert your pr to draft since CI failed

@mergify mergify bot marked this pull request as draft June 3, 2024 14:33
@mergify mergify bot added the CI:fail CI has failed label Jun 3, 2024
@mergify mergify bot marked this pull request as ready for review June 3, 2024 14:44
@mergify mergify bot removed the CI:fail CI has failed label Jun 3, 2024
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team June 5, 2024 07:16
@mergify mergify bot requested a review from a team June 6, 2024 12:34
@Phoenix500526 Phoenix500526 merged commit d4dd8ef into xline-kv:master Jun 7, 2024
12 checks passed
@poltao poltao deleted the improve-fast-round branch June 7, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Return early in fast_round when the amount of KeyConflict large than or equal to recover quorum
3 participants