-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add txn retry logic #776
Conversation
Closes: xline-kv#774 Signed-off-by: Phoeniix Zhao <[email protected]>
7f93597
to
9567c0d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #776 +/- ##
==========================================
+ Coverage 75.55% 75.59% +0.04%
==========================================
Files 180 182 +2
Lines 26938 27056 +118
Branches 26938 27056 +118
==========================================
+ Hits 20353 20454 +101
- Misses 5366 5385 +19
+ Partials 1219 1217 -2 ☔ View full report in Codecov by Sentry. |
9567c0d
to
c51f644
Compare
8f4f038
to
c51f644
Compare
Signed-off-by: Phoeniix Zhao <[email protected]>
c51f644
to
ebda1ef
Compare
Refs: #774
Closes: #774
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
FYI: [Bug]: The test case curp::it server::shutdown_rpc_should_shutdown_the_cluster failed #774
what changes does this pull request make?
Add a retry logic in
write_batch
.are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
There is nothing to change breakingly, but we need to do a performance regression test for this modification.