refactor: implement xline conflict pools #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #769 +/- ##
==========================================
+ Coverage 75.55% 75.57% +0.02%
==========================================
Files 180 187 +7
Lines 26938 27563 +625
Branches 26938 27563 +625
==========================================
+ Hits 20353 20831 +478
- Misses 5366 5450 +84
- Partials 1219 1282 +63 ☔ View full report in Codecov by Sentry. |
rogercloud
reviewed
Apr 17, 2024
|
@bsbds Convert your pr to draft since CI failed |
bsbds
force-pushed
the
impl-xline-conflict-pool
branch
2 times, most recently
from
3de0765 to
bf2e69b
Compare
|
@bsbds Convert your pr to draft since CI failed |
bsbds
force-pushed
the
impl-xline-conflict-pool
branch
2 times, most recently
from
6d8f8cb to
e442e29
Compare
|
@bsbds Convert your pr to draft since CI failed |
1 similar comment
|
@bsbds Convert your pr to draft since CI failed |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Phoenix500526
force-pushed
the
impl-xline-conflict-pool
branch
from
e442e29 to
5b5c201
Compare
|
@bsbds Convert your pr to draft since CI failed |
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
bsbds
force-pushed
the
impl-xline-conflict-pool
branch
from
5b5c201 to
b68a781
Compare
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
bsbds
force-pushed
the
impl-xline-conflict-pool
branch
from
b68a781 to
0ab29e9
Compare
rogercloud
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
This PR implements the conflict pool data structures in xline.
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)