Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add config for dependabot. #697

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

liangyuanpeng
Copy link
Contributor

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

Let dependabot work for auto update github-actions to get rid of deprecated github actions.

Also can update it for argo if you accepts the automatic update of cargo dependencies,

  - package-ecosystem: "cargo"
    directory: "/"
    schedule:
      interval: "weekly"
    labels:
      - "dependencies"
  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.40%. Comparing base (75e51f4) to head (d2229f5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
+ Coverage   74.38%   74.40%   +0.02%     
==========================================
  Files         173      173              
  Lines       25872    25872              
  Branches    25872    25872              
==========================================
+ Hits        19244    19250       +6     
+ Misses       5425     5420       -5     
+ Partials     1203     1202       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add open-pull-requests-limit for this workflow. 10 might be a reasonable value.

@@ -0,0 +1,7 @@
version: 2
updates:
- package-ecosystem: "github-actions"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is github-actions rather than cargo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to auto-update for github-action, so it will let the dependabot create a PR to work for like that:

-       uses: actions/checkout@v3
+       uses: actions/checkout@v4

If you also want cargo to automatically upgrade dependencies, I'd be happy to add the configuration.

Copy link
Contributor Author

@liangyuanpeng liangyuanpeng Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And i think the focus of xline at this stage is on the development of feature, so automatically updating cargo dependencies may not be that important.
No strong opinion from me.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, automatically upgrade cargo dependencies is a good practice.

Copy link
Contributor Author

@liangyuanpeng liangyuanpeng Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Phoenix500526
And just for confirm that you also want to schedule with daily for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @bsbds ^^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion is to use monthly to reduce noise as much as possible at this stage if you want to enable aoto-update for cargo dependenices, and you can update it to weekly later.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, you've convinced me. Daily might be too frequent; weekly is a better option.

.github/dependabot.yml Outdated Show resolved Hide resolved
@liangyuanpeng liangyuanpeng force-pushed the config_dependabot branch 4 times, most recently from a6c066b to 1fe7e87 Compare March 20, 2024 02:42
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsbds bsbds merged commit 423d4da into xline-kv:master Mar 22, 2024
13 checks passed
@liangyuanpeng liangyuanpeng deleted the config_dependabot branch March 22, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants