-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add config for dependabot. #697
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #697 +/- ##
==========================================
+ Coverage 74.38% 74.40% +0.02%
==========================================
Files 173 173
Lines 25872 25872
Branches 25872 25872
==========================================
+ Hits 19244 19250 +6
+ Misses 5425 5420 -5
+ Partials 1203 1202 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add open-pull-requests-limit
for this workflow. 10 might be a reasonable value.
@@ -0,0 +1,7 @@ | |||
version: 2 | |||
updates: | |||
- package-ecosystem: "github-actions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is github-actions
rather than cargo
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to auto-update for github-action, so it will let the dependabot create a PR to work for like that:
- uses: actions/checkout@v3
+ uses: actions/checkout@v4
If you also want cargo to automatically upgrade dependencies, I'd be happy to add the configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And i think the focus of xline at this stage is on the development of feature, so automatically updating cargo dependencies may not be that important.
No strong opinion from me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, automatically upgrade cargo dependencies is a good practice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Phoenix500526
And just for confirm that you also want to schedule with daily
for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @bsbds ^^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion is to use monthly
to reduce noise as much as possible at this stage if you want to enable aoto-update for cargo dependenices, and you can update it to weekly
later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, you've convinced me. Daily might be too frequent; weekly is a better option.
a6c066b
to
1fe7e87
Compare
Signed-off-by: Lan Liang <[email protected]>
1fe7e87
to
d2229f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please briefly answer these questions:
Let dependabot work for auto update github-actions to get rid of deprecated github actions.
Also can update it for argo if you accepts the automatic update of cargo dependencies,
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)