-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/better debug #683
Merged
Phoenix500526
merged 3 commits into
xline-kv:master
from
Phoenix500526:refactor/better-debug
Mar 13, 2024
Merged
Refactor/better debug #683
Phoenix500526
merged 3 commits into
xline-kv:master
from
Phoenix500526:refactor/better-debug
Mar 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phoeniix Zhao <[email protected]>
Signed-off-by: Phoeniix Zhao <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #683 +/- ##
==========================================
- Coverage 74.74% 74.48% -0.27%
==========================================
Files 172 173 +1
Lines 25374 25871 +497
Branches 25374 25871 +497
==========================================
+ Hits 18966 19270 +304
- Misses 5219 5399 +180
- Partials 1189 1202 +13 ☔ View full report in Codecov by Sentry. |
bsbds
previously approved these changes
Mar 11, 2024
rogercloud
reviewed
Mar 12, 2024
bsbds
previously approved these changes
Mar 12, 2024
rogercloud
reviewed
Mar 12, 2024
…instead of Debug trait Signed-off-by: Phoeniix Zhao <[email protected]>
2be11ed
to
dafdb54
Compare
rogercloud
approved these changes
Mar 13, 2024
bsbds
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
Currently, some gRPC requests and responses consist of bytes and are not human-readable. I implemented the Display trait for these requests and responses so they can be output in a more developer-friendly format. The reason for implementing Display instead of Debug is that Prost automatically derives Debug for all requests and responses. This pr can reduce the log content size which mentioned in issue #516 .
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Implement Display trait for some requests and responses
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
no