Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement interval tree #656

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

bsbds
Copy link
Collaborator

@bsbds bsbds commented Feb 20, 2024

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)

    Implements a interval tree, which is useful for dynamic interval update&query.

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@bsbds bsbds marked this pull request as ready for review February 20, 2024 02:36
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 96.30836% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 75.10%. Comparing base (f081173) to head (3e8a9b2).
Report is 17 commits behind head on master.

Files Patch % Lines
crates/utils/src/interval_map/mod.rs 95.41% 28 Missing and 2 partials ⚠️
crates/utils/src/interval_map/tests.rs 98.50% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #656      +/-   ##
==========================================
+ Coverage   75.07%   75.10%   +0.02%     
==========================================
  Files         173      175       +2     
  Lines       25644    26793    +1149     
  Branches    25644    26793    +1149     
==========================================
+ Hits        19253    20122     +869     
- Misses       5187     5466     +279     
- Partials     1204     1205       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/utils/src/interval_map/mod.rs Outdated Show resolved Hide resolved
crates/utils/src/interval_map/mod.rs Outdated Show resolved Hide resolved
crates/utils/src/interval_map/mod.rs Outdated Show resolved Hide resolved
crates/utils/src/interval_map/mod.rs Outdated Show resolved Hide resolved
crates/utils/src/interval_map/mod.rs Outdated Show resolved Hide resolved
crates/utils/src/interval_map/mod.rs Outdated Show resolved Hide resolved
@bsbds bsbds force-pushed the interval-tree branch 4 times, most recently from bee44a9 to cf9655e Compare February 26, 2024 07:05
crates/utils/src/interval_map/tests.rs Outdated Show resolved Hide resolved
crates/utils/src/array_interval_map/mod.rs Outdated Show resolved Hide resolved
@bsbds bsbds force-pushed the interval-tree branch 3 times, most recently from 50037e2 to 40f5a1c Compare February 29, 2024 06:28
@bsbds bsbds mentioned this pull request Feb 29, 2024
@bsbds bsbds force-pushed the interval-tree branch 3 times, most recently from 0218c27 to 083398e Compare March 5, 2024 09:43
Phoenix500526
Phoenix500526 previously approved these changes Mar 11, 2024
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/utils/benches/interval_map.rs Show resolved Hide resolved
crates/utils/src/interval_map/mod.rs Show resolved Hide resolved
crates/utils/src/interval_map/mod.rs Show resolved Hide resolved
crates/utils/src/interval_map/mod.rs Show resolved Hide resolved
crates/utils/src/interval_map/mod.rs Outdated Show resolved Hide resolved
@Phoenix500526
Copy link
Collaborator

Please squash some intermediate commits.

Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit 40763a8 into xline-kv:master Mar 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants