Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upload xline logs if validation failed #573

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

themanforfree
Copy link
Collaborator

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    upload xline logs if validation failed
  • what changes does this pull request make?
    upload xline logs if validation failed
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    no

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa656ad) 64.40% compared to head (e0a388c) 79.07%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #573       +/-   ##
===========================================
+ Coverage   64.40%   79.07%   +14.67%     
===========================================
  Files         105      154       +49     
  Lines       18802    21284     +2482     
  Branches    18802        0    -18802     
===========================================
+ Hits        12109    16830     +4721     
+ Misses       5955     4454     -1501     
+ Partials      738        0      -738     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@themanforfree themanforfree added this to the v0.6.1 milestone Dec 15, 2023
Phoenix500526
Phoenix500526 previously approved these changes Dec 18, 2023
Copy link
Collaborator

@Phoenix500526 Phoenix500526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Phoenix500526
Phoenix500526 previously approved these changes Dec 19, 2023
Signed-off-by: themanforfree <[email protected]>
@themanforfree themanforfree merged commit 8b28bc4 into xline-kv:master Dec 19, 2023
9 checks passed
@themanforfree themanforfree deleted the validation-log branch December 19, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants