feat: reimplement curp client keep alive #1006
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 14 days |
|
This PR was closed because it has been stalled for 14 days with no activity. |
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]> chore: move fetch_impl to upper level chore: move config.rs to upper level Signed-off-by: bsbds <[email protected]> refactor: client fetch Signed-off-by: bsbds <[email protected]>
Signed-off-by: bsbds <[email protected]>
bsbds
force-pushed
the
impl-curp-client-keep-alive
branch
from
9be2253 to
b216c9c
Compare
rogercloud
reviewed
Dec 5, 2024
Comment on lines
+59
to
+61
| // If the leader id cannot be found in connects, it indicates that there is | ||
| // an inconsistency between the client's local leader state and the cluster | ||
| // state, then mock a `WrongClusterVersion` return to the outside. |
There was a problem hiding this comment.
The comment is not correct
rogercloud
reviewed
Dec 6, 2024
| } | ||
|
|
||
| /// Prefetch, send fetch cluster request to the cluster and get the | ||
| /// config with the greatest quorum. |
There was a problem hiding this comment.
Do you mean term number?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #1005
Please briefly answer these questions:
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)