Skip to content

Commit

Permalink
Merge pull request #161 from xiv-gear-planner/dt-buff-adjustments
Browse files Browse the repository at this point in the history
Dawntrail buff adjustments
  • Loading branch information
xpdota authored Jun 28, 2024
2 parents 4a0f5bd + c95be9e commit f2dd197
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 21 deletions.
32 changes: 16 additions & 16 deletions packages/core/src/sims/buffs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,21 @@ export const Dokumori = {
effects: {
dmgIncrease: 0.05,
},
startTime: 3.5,
startTime: 3.40,
statusId: 3849
} as const satisfies PartyBuff;

export const Litany = {
name: "Battle Litany",
saveKey: "Battle Litany",
job: "DRG",
duration: 15,
duration: 20,
cooldown: 120,
selfOnly: false,
effects: {
critChanceIncrease: 0.10
},
startTime: 7.5,
startTime: 5.60,
statusId: 786
} as const satisfies PartyBuff;

Expand All @@ -48,7 +48,7 @@ export const Brotherhood = {
name: "Brotherhood",
saveKey: "Brotherhood",
job: "MNK",
duration: 15,
duration: 20,
cooldown: 120,
selfOnly: false,
effects: {
Expand All @@ -69,7 +69,7 @@ export const ArcaneCircle = {
effects: {
dmgIncrease: 0.03
},
startTime: 5,
startTime: 4.59,
statusId: 2599
} as const satisfies PartyBuff;

Expand All @@ -92,13 +92,13 @@ export const SearingLight = {
name: "Searing Light",
saveKey: "Searing Light",
job: "SMN",
duration: 30,
duration: 20,
cooldown: 120,
selfOnly: false,
effects: {
dmgIncrease: 0.03
},
startTime: 1.5,
startTime: 4.7,
statusId: 2703
} as const satisfies PartyBuff;

Expand All @@ -112,7 +112,7 @@ export const Embolden = {
effects: {
dmgIncrease: 0.05
},
startTime: 7,
startTime: 6.5,
// This is the party member version of this, not the self version
statusId: 1297
} as const satisfies PartyBuff;
Expand All @@ -129,7 +129,7 @@ export const Devilment = {
dhitChanceIncrease: 0.20,
critChanceIncrease: 0.20
},
startTime: 7,
startTime: 7.2,
statusId: 1825
} as const satisfies PartyBuff;

Expand Down Expand Up @@ -170,35 +170,35 @@ export const BattleVoice = {
name: "Battle Voice",
saveKey: "Battle Voice",
job: "BRD",
duration: 15,
duration: 20,
cooldown: 120,
selfOnly: false,
effects: {
dhitChanceIncrease: 0.20,
},
startTime: 6,
startTime: 6.4,
statusId: 141
} as const satisfies PartyBuff;

export const RadiantFinale = {
name: "Radiant Finale",
saveKey: "Radiant Finale",
job: "BRD",
duration: 15,
duration: 20,
cooldown: 120,
selfOnly: false,
effects: {
dmgIncrease: 0.06
},
startTime: 6.7,
startTime: 5.7,
statusId: 2964
} as const satisfies PartyBuff;

export const Chain = {
name: "Chain",
saveKey: "Chain",
job: "SCH",
duration: 15,
duration: 20,
cooldown: 120,
selfOnly: false,
effects: {
Expand All @@ -212,7 +212,7 @@ export const Divination = {
name: "Divination",
saveKey: "Divination",
job: "AST",
duration: 15,
duration: 20,
cooldown: 120,
selfOnly: false,
effects: {
Expand All @@ -227,7 +227,7 @@ export const AstCard = {
saveKey: "Single Target AST Card",
job: "AST",
duration: 15,
cooldown: 30,
cooldown: 120,
selfOnly: false,
optional: true,
effects: {
Expand Down
10 changes: 5 additions & 5 deletions packages/frontend/src/scripts/test/sims/cycle_processor_tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ const expectedAbilities: UseResult[] = [
{
time: 5.45,
name: 'Glare',
damage: 15828.682
damage: 16652.989
},
{
time: 6.93,
Expand Down Expand Up @@ -361,17 +361,17 @@ const expectedAbilities: UseResult[] = [
{
time: 22.48,
name: "Glare",
damage: 15828.682
damage: 17652.168
},
{
time: 24.32,
name: "Glare",
damage: 15074.935
damage: 16811.589
},
{
time: 25.928,
name: "Auto Attack",
damage: 33.301
damage: 35.299
},
{
time: 26.63,
Expand Down Expand Up @@ -400,7 +400,7 @@ describe('Cycle sim processor', () => {
// Run simulation
const result = await inst.simulate(set);
// Assert correct results
assertClose(result.mainDpsResult, 9896.58, 0.01);
assertClose(result.mainDpsResult, 10040.777, 0.01);
assertSimAbilityResults(result, expectedAbilities);
});
});
Expand Down

0 comments on commit f2dd197

Please sign in to comment.