Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploy CI job #3399

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Fix deploy CI job #3399

merged 1 commit into from
Sep 23, 2024

Conversation

FreezyLemon
Copy link
Contributor

@FreezyLemon FreezyLemon commented Sep 23, 2024

Closes #3397.

proof that it works (the commit on that branch includes another change for testing).

GHA uses pwsh by default on Windows runners. Powershell uses backticks instead of backslashes.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (3c3a26f) to head (2fe5a2e).
Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3399      +/-   ##
==========================================
- Coverage   88.52%   82.14%   -6.39%     
==========================================
  Files          89       89              
  Lines       28323    27408     -915     
==========================================
- Hits        25074    22515    -2559     
- Misses       3249     4893    +1644     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lu-zero
Copy link
Collaborator

lu-zero commented Sep 23, 2024

Thank you!

@lu-zero lu-zero merged commit 09a4111 into xiph:master Sep 23, 2024
26 of 27 checks passed
@FreezyLemon FreezyLemon deleted the ci-fix-deploy-job branch September 23, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix deploy CI job
2 participants