Resolved issue #4 Support bullet lists starting with * or + #18
Conversation
| NSParagraphStyleAttributeName: paragraphStyle}; | ||
| label.attributedText = [parser attributedStringFromMarkdownString:markdown]; | ||
|
|
||
| FBSnapshotVerifyView(label, nil); |
There was a problem hiding this comment.
why have you replaced this test?
|
@maodd thanks for your pull request! However, tests are still red, could you please fix them in order to merge your changes? Thanks! |
|
@maodd it looks the problem is that you are running tests against iOS 9 and the CI runs them on iOS 8.1. Could you please replace it in the Rakefile? Travis should be able to run the tests on iOS 9.3: https://docs.travis-ci.com/user/languages/objective-c/ |
|
I re did record in iOS 8.1 instead. but seems still couldn't make test happy. one of the failed test is testHeaders:
I just can't tell the difference between those 2 images. |
|
test plaintext result: snapshot image area look different. why?
|
|
Really can't tell the difference in testStyles result:
|
|
Font Change results compare:
|
|
test paragraph result compare:
|
|
Good news is 3 of 8 tests passed (including my newly added testLists) |
|
OK. all tests passed now. need to record in iPhone5s. |
…ing#12 Ignore Acronym in URL detection
| case MARKDOWN_NEWLINE: { | ||
| textAsString = @""; | ||
| break; | ||
| } | ||
| case MARKDOWN_URL: { | ||
|
|
||
| if ([textAsString hasPrefix:@"@"]) { |
There was a problem hiding this comment.
this for another issue (#17) reported and I also encountered, domain in email address shouldn't not be rendered as link. I tried to do pure regex fix, no good. ended up with let regex expend optional leading at sign (@) , and let code to skip domain in email.
There was a problem hiding this comment.
Well, that might be valid as a temporal fix
|
Thanks for fixing the tests @maodd ! I just left a small comment on your code, after you answer we can merge the PR :) |
Nothing special, original state was - syntax only. I added * and + in grammar file, re-run generate command to update token file. Only issue was * conflicting with em1 syntax (** **), trick is to pull list parser before em.