[cmake] Revert "make use of "enable_examples" in CMakeLists.txt" #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts parts of commit 367fd39. The use of "enable_examples" is in EXAMPLES/CMakeLists.txt. The advanatge of the solution is that even with disabled enable_examples the exmaples can be manually built.
|
@xiaoyeli Your last change was a regression, the behavior is what you expect (or even better). If you need more detailed explanation, please let me know. |
|
That's a good point. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts parts of commit 367fd39.
The use of
enable_examplesis in EXAMPLES/CMakeLists.txt. The advantage of the solution is that even with disabled enable_examples the examples can be manually built.