feat: refactor highlighter

xiangechen · Jul 16, 2024 · e7c2f8a · e7c2f8a
1 parent d929012
commit e7c2f8a
Show file tree

Hide file tree

Showing 14 changed files with 630 additions and 168 deletions.
diff --git a/packages/chili-core/src/visual/visualShape.ts b/packages/chili-core/src/visual/visualShape.ts
@@ -5,7 +5,7 @@ import { IVisualObject } from "./visualObject";
 
 export enum VisualState {
     normal = 0,
-    highlight = 1,
+    highlighter = 1,
     selected = 1 << 1,
 }
 

diff --git a/packages/chili-core/test/visual.test.ts b/packages/chili-core/test/visual.test.ts
@@ -7,35 +7,35 @@ describe("visual test", () => {
         let state = VisualState.normal;
         expect(state).toBe(0);
 
-        state = VisualState.addState(state, VisualState.highlight);
+        state = VisualState.addState(state, VisualState.highlighter);
         expect(state).toBe(1);
-        expect(VisualState.hasState(state, VisualState.highlight)).toBeTruthy();
+        expect(VisualState.hasState(state, VisualState.highlighter)).toBeTruthy();
         expect(VisualState.hasState(state, VisualState.selected)).toBeFalsy();
 
         state = VisualState.addState(state, VisualState.selected);
         expect(state).toBe(3);
-        expect(VisualState.hasState(state, VisualState.highlight)).toBeTruthy();
+        expect(VisualState.hasState(state, VisualState.highlighter)).toBeTruthy();
         expect(VisualState.hasState(state, VisualState.selected)).toBeTruthy();
 
-        state = VisualState.removeState(state, VisualState.highlight);
+        state = VisualState.removeState(state, VisualState.highlighter);
         expect(state).toBe(2);
-        expect(VisualState.hasState(state, VisualState.highlight)).toBeFalsy();
+        expect(VisualState.hasState(state, VisualState.highlighter)).toBeFalsy();
         expect(VisualState.hasState(state, VisualState.selected)).toBeTruthy();
 
         state = VisualState.removeState(state, VisualState.selected);
         expect(state).toBe(0);
-        expect(VisualState.hasState(state, VisualState.highlight)).toBeFalsy();
+        expect(VisualState.hasState(state, VisualState.highlighter)).toBeFalsy();
         expect(VisualState.hasState(state, VisualState.selected)).toBeFalsy();
 
-        state = VisualState.highlight;
+        state = VisualState.highlighter;
         state = VisualState.addState(state, VisualState.selected);
         expect(state).toBe(3);
-        expect(VisualState.hasState(state, VisualState.highlight)).toBeTruthy();
+        expect(VisualState.hasState(state, VisualState.highlighter)).toBeTruthy();
         expect(VisualState.hasState(state, VisualState.selected)).toBeTruthy();
 
-        state = VisualState.removeState(state, VisualState.highlight);
+        state = VisualState.removeState(state, VisualState.highlighter);
         expect(state).toBe(2);
-        expect(VisualState.hasState(state, VisualState.highlight)).toBeFalsy();
+        expect(VisualState.hasState(state, VisualState.highlighter)).toBeFalsy();
         expect(VisualState.hasState(state, VisualState.selected)).toBeTruthy();
     });
 });