🎈 perf: Shortcut keys to toggle view translation and rotation

xiangechen · Mar 6, 2024 · 0ce306a · 0ce306a
1 parent 9b45dfa
commit 0ce306a
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/packages/chili-three/src/threeViewEventHandler.ts b/packages/chili-three/src/threeViewEventHandler.ts
@@ -13,7 +13,11 @@ export class ThreeViewHandler implements IEventHandler {
     private _lastDown: MouseDownData | undefined;
     private _clearDownId: number | undefined;
 
-    dispose() {}
+    canRotate: boolean = true;
+
+    dispose() {
+        this.clearTimeout();
+    }
 
     mouseWheel(view: IView, event: WheelEvent): void {
         view.cameraController.zoom(event.offsetX, event.offsetY, event.deltaY);
@@ -22,10 +26,10 @@ export class ThreeViewHandler implements IEventHandler {
 
     pointerMove(view: IView, event: PointerEvent): void {
         if (event.buttons === MIDDLE) {
-            if (event.shiftKey) {
-                view.cameraController.pan(event.movementX, event.movementY);
-            } else if (!event.shiftKey) {
+            if (event.shiftKey && this.canRotate) {
                 view.cameraController.rotate(event.movementX, event.movementY);
+            } else if (!event.shiftKey) {
+                view.cameraController.pan(event.movementX, event.movementY);
             }
             if (event.movementX !== 0 && event.movementY !== 0) this._lastDown = undefined;
             view.update();