🦄 refactor: Adjusted code organization for shape

xiangechen · Jun 15, 2024 · 08ad255 · 08ad255
1 parent ac01429
commit 08ad255
Show file tree

Hide file tree

Showing 6 changed files with 33 additions and 38 deletions.
diff --git a/packages/chili-core/src/shape/curve.ts b/packages/chili-core/src/shape/curve.ts
@@ -1,7 +1,19 @@
 // Copyright 2022-2023 the Chili authors. All rights reserved. AGPL-3.0 license.
 
 import { XYZ } from "../math";
-import { CurveType } from "./shape";
+
+export enum CurveType {
+    Line,
+    Circle,
+    Ellipse,
+    Hyperbola,
+    Parabola,
+    BezierCurve,
+    BSplineCurve,
+    OffsetCurve,
+    OtherCurve,
+    TrimmedCurve,
+}
 
 export enum Continuity {
     C0,

diff --git a/packages/chili-core/src/shape/shape.ts b/packages/chili-core/src/shape/shape.ts
@@ -7,35 +7,6 @@ import { IShapeMeshData } from "./meshData";
 import { ShapeType } from "./shapeType";
 import { ISurface } from "./surface";
 
-export enum CurveType {
-    Line,
-    Circle,
-    Ellipse,
-    Hyperbola,
-    Parabola,
-    BezierCurve,
-    BSplineCurve,
-    OffsetCurve,
-    OtherCurve,
-    TrimmedCurve,
-}
-
-export enum SurfaceType {
-    Plate,
-    Bezier,
-    BSpline,
-    RectangularTrimmed,
-    Conical,
-    Cylinder,
-    Plane,
-    Spherical,
-    Toroidal,
-    Revolution,
-    Extrusion,
-    Offset,
-    Composite,
-}
-
 export enum Orientation {
     FORWARD,
     REVERSED,

diff --git a/packages/chili-core/src/shape/surface.ts b/packages/chili-core/src/shape/surface.ts
@@ -3,6 +3,22 @@
 import { Plane, XYZ } from "../math";
 import { Continuity, ICurve } from "./curve";
 
+export enum SurfaceType {
+    Plate,
+    Bezier,
+    BSpline,
+    RectangularTrimmed,
+    Conical,
+    Cylinder,
+    Plane,
+    Spherical,
+    Toroidal,
+    Revolution,
+    Extrusion,
+    Offset,
+    Composite,
+}
+
 export interface ISurface {
     continuity(): Continuity;
     uIso(u: number): ICurve;

diff --git a/packages/chili-occ/src/occCurve.ts b/packages/chili-occ/src/occCurve.ts
@@ -25,14 +25,13 @@ import {
     Geom_Circle,
     Geom_Conic,
     Geom_Curve,
+    Geom_Ellipse,
     Geom_Hyperbola,
     Geom_Line,
     Geom_OffsetCurve,
     Geom_Parabola,
     Geom_TrimmedCurve,
 } from "../occ-wasm/chili_occ";
-
-import { Geom_Ellipse } from "opencascade.js/dist/opencascade.full";
 import { OccHelps } from "./occHelps";
 
 export class OccCurve implements ICurve, IDisposable {

diff --git a/packages/chili-occ/src/occHelps.ts b/packages/chili-occ/src/occHelps.ts
@@ -18,7 +18,6 @@ import {
 import {
     GeomAbs_JoinType,
     GeomAbs_Shape,
-    GeomPlate_Surface,
     Geom_BSplineCurve,
     Geom_BezierCurve,
     Geom_Circle,
@@ -29,7 +28,6 @@ import {
     Geom_OffsetCurve,
     Geom_Parabola,
     Geom_Surface,
-    Geom_SurfaceOfRevolution,
     Geom_TrimmedCurve,
     TopAbs_ShapeEnum,
     TopTools_ListOfShape,
@@ -393,7 +391,7 @@ export class OccHelps {
     static fromArray(shapes: IShape[]): TopTools_ListOfShape {
         let listOfShape = new occ.TopTools_ListOfShape_1();
         shapes.forEach((shape) => {
-            if (!(shape instanceof OccFace)) {
+            if (!(shape instanceof OccShape)) {
                 throw new Error("The OCC kernel only supports OCC geometries.");
             }
             listOfShape.Append_1(shape.shape);

diff --git a/packages/chili-occ/src/occShape.ts b/packages/chili-occ/src/occShape.ts
@@ -28,7 +28,6 @@ import {
 } from "chili-core";
 import {
     BOPTools_AlgoTools3D,
-    BRepTools,
     BRep_Tool,
     TopoDS_Edge,
     TopoDS_Face,
@@ -70,11 +69,11 @@ export class OccShape implements IShape {
         this.shapeType = OccHelps.getShapeType(shape);
     }
     isEmpty(): boolean {
-        return BOPTools_AlgoTools3D.IsEmptyShape(this.shape);
+        return occ.BOPTools_AlgoTools3D.IsEmptyShape(this.shape);
     }
 
     isClosed(): boolean {
-        return BRep_Tool.IsClosed_1(this.shape);
+        return occ.BRep_Tool.IsClosed_1(this.shape);
     }
 
     section(shape: IShape | Plane): IShape {