Fixes to DashContainerModel state handling + renders #3839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ State updates were being dropped if new state applied during re-render, when ref not available. + Observed in use case with ViewManager, where the parent component was being moved in the layout at same time as new dash state applied. + Don't ignore state updates if not rendered - store and save for later application. + But improve ref reaction and async state application code to avoid unintended / overlapping application of state when both state and render changing at the same time.
amcclain
commented
Nov 22, 2024
| @@ -214,8 +214,12 @@ export class DashContainerModel | |||
| // Initialize GoldenLayout with initial state once ref is ready | |||
| this.addReaction( | |||
| { | |||
| track: () => [this.containerRef.current, this.layoutLocked], | |||
| run: () => this.loadStateAsync(this.state) | |||
| track: () => [this.containerRef.current, this.layoutLocked] as const, | |||
There was a problem hiding this comment.
I did not test the layoutLocked change path, but good to ensure that all working as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
developbranch as of last change.breaking-changelabel + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.