-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages in generated projects #355
Update packages in generated projects #355
Conversation
Hey, I looked briefly on packages with breaking updates (based on version numbers) and only thing I wonder is whether olegskl/gulp-stylelint#85 is still an issue? |
@jakub300 good call. Unfortunately, it's still an issue even in the latest 7.0.0 version, did a few tests with my test case here https://github.com/luboskmetko/test-gulp-stylelint We could keep 3.9.0 version but that one uses stylelint v7.13.0 and there have been a lot of changes and fixes in stylelint since then (now at v9.1.3). Not sure if that causes any troubles in real projects, but we probably should think how to address this without relying on a fix in cc @arturkot |
Could you try to go back to not working version and ignore vendor by passing it to gulp.src([path.join(src.base, src.styles), `!${path.join(src.base, 'styles/vendor/**/*')}`]) If it works I think it would be enough for us. |
Actually, it's not only about |
It looks like you downgraded gulp-stylelint back to old version but stylelint v9 is still in dependencies |
@jakub300 I've removed stylelint v9 from dependencies |
Fixes #353
Also added
eslint
andstylelint
as dependencies. Didn't update Gulp and Webpack to v4 as those produce some errors which require a more detailed look.