CA-248332: Fix race condition in iostat while updating VDI-to-VM map.

There is a window when the tapdisk is created but the VBDs are not, and if VDI-to-VM map is updated during this window then the daemon will not try to update the map again until the next tapdisk is created. This fix will call `update_vdi_to_vm_map` if any of the tapdisk known doesn't have corresponding entries in the VDI-to-VM map. Signed-off-by: Sharad Yadav <[email protected]>
xenserver · Apr 20, 2017 · e629486 · e629486
1 parent a53ed5e
commit e629486
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/rrdp_iostat.ml b/src/rrdp_iostat.ml
@@ -258,7 +258,7 @@ let exec_tap_ctl () =
 			update_vdi_to_vm_map ()
 		end else
 			let disappeared_pids = List.set_difference !previous_map pid_and_minor_to_sr_and_vdi in
-			let appeared_pids    = List.set_difference pid_and_minor_to_sr_and_vdi !previous_map in
+			let unmapped_vdi_pids = List.filter (fun (_, (_, (_, vdi))) -> not (List.mem_assoc vdi !vdi_to_vm_map)) pid_and_minor_to_sr_and_vdi in
 
 			List.iter (fun (pid, (_, (_, vdi))) ->
 				try
@@ -268,9 +268,9 @@ let exec_tap_ctl () =
 					D.debug "no knowledge about pid %d; ignoring" pid
 			) disappeared_pids;
 
-			if appeared_pids <> [] then begin
+			if unmapped_vdi_pids <> [] then begin
 				let pids_to_string pids = pids |> List.map (fun (pid, (_, (_, vdi))) -> Printf.sprintf "%d (%s)" pid vdi) |> String.concat "; " in
-				D.info "There are new tapdisk processes: [%s]; updating VDI-to-VM map..." (pids_to_string appeared_pids);
+				D.info "There are new tapdisk processes: [%s]; updating VDI-to-VM map..." (pids_to_string unmapped_vdi_pids);
 				(* Unfortunately the only way of identifying which VMs the new tapdisks service is to refresh the entire map *)
 				update_vdi_to_vm_map ()
 			end