Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements #151

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Some improvements #151

wants to merge 4 commits into from

Conversation

mikelei8291
Copy link

This PR adds the following improvements to the project:

  1. Added superchat to default message groups of YouTube (was Add superchat to default message groups of YouTube #126, closed due to unwanted commit got pushed, see #126-comment)
  2. Changed the default value of the title attribute of the Chat object from None to an empty string (see #126-comment)
  3. Changed to set the exit status to 1 if any error caused the program to exit

For 1 and 2, please see the referred PR and comment.

For 3, the current implementation will set the exit status to 1 on any exceptions raised, including the KeyboardInterrupt. However, if you want to set different exit statuses for different exceptions, the value can be customized by returning directly at the end of each except block. This can be useful when waiting for the chat to become available using a while loop in the shell, if the chat was disabled until the live started. Given that the project doesn't have a built-in solution for waiting for the chat to become available, this small change would solve the problem with minimal effort, and it is also a common practice to set the exit status of a program to non-zero values if the exit was caused by errors.

@mikelei8291
Copy link
Author

@xenova Sorry for pinging you. Would you like to review this pr and see if it can be merged to the repo? You could also close this pr if you don't, but I've been waiting for a response for over half a year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants