Skip to content

Commit

Permalink
arch: drop get_processor_id()
Browse files Browse the repository at this point in the history
smp_processor_id() is what we commonly use; there's no need for it to
have an alias.

Signed-off-by: Jan Beulich <[email protected]>
Reviewed-by: Oleksii Kurochko <[email protected]>
Reviewed-by: Bertrand Marquis <[email protected]> # arm
Reviewed-by: Roger Pau Monné <[email protected]>
  • Loading branch information
jbeulich committed Nov 3, 2023
1 parent ad193a7 commit 86b0629
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 14 deletions.
2 changes: 1 addition & 1 deletion xen/arch/arm/include/asm/current.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ static inline struct cpu_info *get_cpu_info(void)

DECLARE_PER_CPU(unsigned int, cpu_id);

#define get_processor_id() this_cpu(cpu_id)
#define smp_processor_id() this_cpu(cpu_id)
#define set_processor_id(id) \
do { \
WRITE_SYSREG(__per_cpu_offset[(id)], TPIDR_EL2); \
Expand Down
2 changes: 0 additions & 2 deletions xen/arch/arm/include/asm/smp.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask);

#define cpu_is_offline(cpu) unlikely(!cpu_online(cpu))

#define smp_processor_id() get_processor_id()

/*
* Do we, for platform reasons, need to actually keep CPUs online when we
* would otherwise prefer them to be off?
Expand Down
2 changes: 1 addition & 1 deletion xen/arch/arm/smpboot.c
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ void start_secondary(void)
/* Shut down the current CPU */
void __cpu_disable(void)
{
unsigned int cpu = get_processor_id();
unsigned int cpu = smp_processor_id();

local_irq_disable();
gic_disable_cpu();
Expand Down
2 changes: 1 addition & 1 deletion xen/arch/x86/include/asm/current.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ static inline struct cpu_info *get_cpu_info(void)
#define set_current(vcpu) (get_cpu_info()->current_vcpu = (vcpu))
#define current (get_current())

#define get_processor_id() (get_cpu_info()->processor_id)
#define smp_processor_id() (get_cpu_info()->processor_id)
#define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs)

/*
Expand Down
7 changes: 0 additions & 7 deletions xen/arch/x86/include/asm/smp.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,6 @@ extern void cpu_exit_clear(unsigned int cpu);
extern void cpu_uninit(unsigned int cpu);
int cpu_add(uint32_t apic_id, uint32_t acpi_id, uint32_t pxm);

/*
* This function is needed by all SMP systems. It must _always_ be valid
* from the initial startup. We map APIC_BASE very early in page_setup(),
* so this is correct in the x86 case.
*/
#define smp_processor_id() get_processor_id()

void __stop_this_cpu(void);

long cf_check cpu_up_helper(void *data);
Expand Down
4 changes: 2 additions & 2 deletions xen/arch/x86/mm/mm-locks.h
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ static inline void mm_rwlock_init(mm_rwlock_t *l)

static inline int mm_write_locked_by_me(mm_rwlock_t *l)
{
return (l->locker == get_processor_id());
return (l->locker == smp_processor_id());
}

static inline void _mm_write_lock(const struct domain *d, mm_rwlock_t *l,
Expand All @@ -132,7 +132,7 @@ static inline void _mm_write_lock(const struct domain *d, mm_rwlock_t *l,
{
_check_lock_level(d, level);
percpu_write_lock(p2m_percpu_rwlock, &l->lock);
l->locker = get_processor_id();
l->locker = smp_processor_id();
l->locker_function = func;
l->unlock_level = _get_lock_level();
_set_lock_level(_lock_level(d, level));
Expand Down

0 comments on commit 86b0629

Please sign in to comment.