Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian: Install xl2tpd.service #264

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wjt
Copy link
Contributor

@wjt wjt commented Feb 16, 2024

9ef5b21 added debian/xl2tpd.service. But since dh_installsystemd was not run during package build, the file was not actually included in the package.

Add that step.

(As far as I can tell, I did not notice this when submitting #226 because I was testing the change against an older branch of xl2tpd, which predated d666b43 and so was on an older debhelper compat level (10). According to https://www.man7.org/linux/man-pages/man7/debhelper-compat-upgrade-checklist.7.html, compat level 12 removed handling of systemd units from dh_installinit. )

9ef5b21 added debian/xl2tpd.service.
But since dh_installsystemd was not run during package build, the file
was not actually included in the package.

Add that step.
@wjt
Copy link
Contributor Author

wjt commented Feb 16, 2024

As an aside: it might be feasible to switch debian/rules to define a rule like the following:

%:
	dh $@

and remove all other rules, replacing them with override_dh_foo: rules as needed. That would have avoided this problem because dh_installsystemd is part of the default sequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant