Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing damage type for spells #1673

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

marvin9257
Copy link
Collaborator

@marvin9257 marvin9257 commented Oct 28, 2024

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fixes

  • What is the current behavior? (You can also link to an open issue here)
    Can't set damage types for spells
    Traveller Tools (TT) character import macro no longer works for TTv1

  • What is the new behavior (if this is a feature change)?
    Can set spell damage type
    Revised macro to work with either version of TT

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Other information:

@marvin9257 marvin9257 merged commit 7a826c2 into xdy:master Oct 28, 2024
8 checks passed
@marvin9257 marvin9257 deleted the fix-missing-damage-type-for-spells branch October 28, 2024 14:11
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
## [5.10.1](v5.10.0...v5.10.1) (2024-10-28)

### Bug Fixes

* missing damage type for spells ([#1673](#1673)) ([7a826c2](7a826c2))
Copy link

🎉 This PR is included in version 5.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant