Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/expose segments #121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/expose segments #121

wants to merge 2 commits into from

Conversation

jamieforth
Copy link

This addresses a couple of small issues with segment metadata.

When dejitter_timestamps=False reported segments now have the correct sample stop.

When dejitter_timestamps=True

  • non-empty streams no longer contain duplicate segment tuples
  • empty stream now return segments as an empty array, rather than [0, -1]

@jamieforth
Swap dimensions of empty stream arrays to match non-empty streams
cba827c 
This ensures the length of empty streams is zero, and not equal to
the number of channels.
@jamieforth
Fix duplicate and spurious segments
f86622e 
* Ensure segment array is initialised only once

* Empty streams return empty segment arrays
@cbrnr
Copy link
Contributor

cbrnr commented Nov 22, 2024

@agricolab do you have time to look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamieforth @cbrnr