-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the code according to the Google C++ Style Guide #27
base: main
Are you sure you want to change the base?
Conversation
Where does the style guide say that function names must be camel case? |
@cbrnr I agree it looks a bit odd; it's not even camel case, it's Pascal case. It says it here: https://google.github.io/styleguide/cppguide.html#Function_Names The C++ standard library does not adopt this style though http://www.cplusplus.com/reference/algorithm/ |
It's your decision. Coming mainly from Python this looks really weird. |
@cbrnr By looking at this thread, looks like the |
Yes, I'd go with the conventions used in the standard lib (at least for this case). |
Personally, I prefer the LLVM over the Google style guide, but any style is an improvement over an inconsistent or undocumented style. Two things: Having the compiled doxygen documentation in the repository adds a lot of noise to the commits. For liblsl, we use readthedocs to host the doxygen output so only the doxygen configuration files are in the repository. One other option is to include the doxygen output in the released archives so anyone downloading it has the html documentation. The other things I'm missing is a clang-format file (labstreaminglayer example, interactive clang-format generator so that Visual Studio / QtCreator can automatically reformat the code according to the style guide. |
@tstenner Thank you for your input, sounds great. I will look into these over the weekend. |
#25
Standardize code style according to https://google.github.io/styleguide/cppguide.html.
Didn't have time to do functionality change, only style cleanup for now.
Note that some method name changes require the code changes in SigViewer as well.