Skip to content

Commit

Permalink
Fixed potentially uninitialized variable (#41)
Browse files Browse the repository at this point in the history
In the case where the file has reached the end, readBin doesn't initialize the "bytes" variable. It therefore contains garbage values, which has a small chance of making the switch select another case than "default", leading to an infinite loop. This isn't just speculation, this has actually happened to me while compiling in Unreal 5.3.
It is worth mentionning that the idiomatic way of checking whether or not the file has reached the end is to use file.eof() instead of relying on the fact that the variable isn't touched by "read".
  • Loading branch information
antoine21839 authored Jul 10, 2024
1 parent 622fcd6 commit 45dbf90
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion xdf.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ void Xdf::resample(int userSrate)
//function of reading the length of each chunk
uint64_t Xdf::readLength(std::ifstream &file)
{
uint8_t bytes;
uint8_t bytes = 0;
Xdf::readBin(file, &bytes);
uint64_t length = 0;

Expand Down

0 comments on commit 45dbf90

Please sign in to comment.