Bug Fix: Reset button still enabled after restoring the original state manually #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deactivated if the initial state was restored.
|
AB-xdev
requested changes
Oct 18, 2024
Comment on lines
+526
to
+534
| final List<ChipBadgeExtension<FilterCondition<T, ?>>> initialChipBadgesCopy | ||
| = new ArrayList<>(this.initialChipBadges); | ||
| final List<ChipBadgeExtension<FilterCondition<T, ?>>> chipBadgesCopy | ||
| = new ArrayList<>(this.chipBadges); | ||
|
|
||
| // Check if just the initial filter are currently applied. Then enable/disable the reset button as | ||
| // appropriate. | ||
| this.btnResetFilter.setEnabled( | ||
| !new FilterComponentUtl<T>().equalLists(initialChipBadgesCopy, chipBadgesCopy)); |
There was a problem hiding this comment.
I think the comparison can be done a in a simpler way using something like this:
this.initialChipBadges.stream()
.map(ChipBadge::getBadgeId)
.collect(Collectors.toSet())
.equals(this.chipBadges.stream()
.map(ChipBadge::getBadgeId)
.collect(Collectors.toSet()))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Expected behavior: After removing the custom condition in step 3, the reset button should no longer be enabled.