New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deep-merge with nil arguments and values #22

Merged

itoooo merged 1 commit into master from fix/deep-merge

Apr 24, 2024

Member

federkasten commented Apr 24, 2024

I corrected the behavior of the deep-merge function for nil arguments and nil values in a map. Here's what I did:

(deep-merge {:foo 1} nil)        ;; => {:foo 1}
(deep-merge nil {:foo 1})        ;; => {:foo 1}
(deep-merge {:foo 1} {:foo nil}) ;; => {:foo 1}
(deep-merge {:foo nil} {:foo 1}) ;; => {:foo 1}


          fix: deep-merge with nil args or values

917fc94

federkasten requested a review from itoooo

April 24, 2024 10:21

federkasten self-assigned this

itoooo approved these changes

View reviewed changes

Contributor

itoooo left a comment

Thank you for the fix! LGTM 👍

itoooo merged commit 82783fd into master

33 checks passed

itoooo deleted the fix/deep-merge branch

April 24, 2024 12:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet