Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game OSD: Video filter dialog updates #12852

Merged
merged 5 commits into from
Oct 4, 2017
Merged

Conversation

garbear
Copy link
Member

@garbear garbear commented Sep 28, 2017

This PR concludes the work I've done to enable the GSoC shader work (garbear#86) to be eventually included in master:

Also included are some features requested on the forum:

  • Set ID 1 to dialog names for View Mode and Video Filter dialogs (request post)
  • Close OSD when "m" is pressed (same post)

Motivation and Context

Final changes required for shaders.

How Has This Been Tested?

Tested in Windows, Linux, OSX and RPi

Screenshots (if appropriate):

screen shot 2017-09-28 at 12 35 25 pm

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@garbear garbear added this to the L 18.0-alpha1 milestone Sep 28, 2017
@garbear
Copy link
Member Author

garbear commented Oct 4, 2017

Fixed a TODO that I left for fixing a threading issue. I think this can go in now. jenkins build this please

@garbear garbear merged commit 5d4bb33 into xbmc:master Oct 4, 2017
@garbear garbear deleted the video-filter branch October 4, 2017 18:15
@Rechi Rechi added the v18 Leia label Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants