Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imdb fix to scrape all genres #441

Open
wants to merge 1 commit into
base: gotham
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metadata.common.imdb.com/addon.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<addon id="metadata.common.imdb.com"
name="IMDB Scraper Library"
version="3.2.7"
version="3.2.8"
provider-name="Team Kodi">
<requires>
<import addon="xbmc.metadata" version="2.1.0"/>
Expand Down
3 changes: 3 additions & 0 deletions metadata.common.imdb.com/changelog.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[B]3.2.8[/B]
- fixed: movies with more than 3 genres not scrapped. Changed GetIMDBGenresById and ParseIMDBGenres to use xx-reference.html

[B]3.2.5[/B]
- fixed: GetIMDBPlotById, ParseIMDBPlot, GetIMDBTaglineById, ParseIMDBTagline to use xx-reference.html

Expand Down
17 changes: 4 additions & 13 deletions metadata.common.imdb.com/imdb.xml
Original file line number Diff line number Diff line change
@@ -1,26 +1,17 @@
<?xml version="1.0" encoding="UTF-8"?>
<scraperfunctions>
<GetIMDBGenresById dest="5">
<RegExp input="$$1" output="&lt;details&gt;&lt;url cache=&quot;$$1-main.html&quot; function=&quot;ParseIMDBGenres&quot;&gt;https://www.imdb.com/title/$$1/|accept-language=en-us&lt;/url&gt;&lt;/details&gt;" dest="5">
<RegExp input="$$1" output="&lt;details&gt;&lt;url cache=&quot;$$1-reference.html&quot; function=&quot;ParseIMDBGenres&quot;&gt;https://www.imdb.com/title/$$1/|accept-language=en-us&lt;/url&gt;&lt;/details&gt;" dest="5">
<expression noclean="1" />
</RegExp>
</GetIMDBGenresById>
<ParseIMDBGenres dest="5">
<RegExp input="$$2" output="&lt;details&gt;\1&lt;/details&gt;" dest="5">
<RegExp input="$$1" output="\1" dest="6">
<expression noclean="1">,&quot;genre&quot;:\[([^\]]+)]</expression>
</RegExp>
<RegExp input="$$6" output="&lt;genre&gt;\1&lt;/genre&gt;" dest="2">
<expression repeat="yes">&quot;([^&quot;]+)&quot;</expression>
</RegExp>
<RegExp input="$$1" output="\1" dest="6">
<expression noclean="1">,\s*&quot;genre&quot;:\s(&quot;[^&quot;]+&quot;),</expression>
</RegExp>
<RegExp input="$$1" output="\1" dest="6">
<expression noclean="1">&quot;genre&quot;:\s\[(.*?)\]</expression>
</RegExp>
<expression noclean="1">label&quot;&gt;Genres&lt;/td&gt;(.*?)&lt;/td&gt;</expression>
</RegExp>
<RegExp input="$$6" output="&lt;genre&gt;\1&lt;/genre&gt;" dest="2">
<expression repeat="yes">&quot;([^&quot;]+)&quot;</expression>
<expression repeat="yes">&lt;a href=.*?&gt;(.*?)&lt;/a&gt;</expression>
</RegExp>
<expression noclean="1" />
</RegExp>
Expand Down