Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Sort settings array before displaying #982

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

wutschel
Copy link
Collaborator

@wutschel wutschel commented Feb 3, 2024

Description

partially solves #981.

Sort the array of values before displaying it in the settings UI.

Summary for release notes

Improvement: Sort settings array before displaying

@kambala-decapitator
Copy link
Collaborator

but it still won't show setting names, only indexes, will it?

@wutschel
Copy link
Collaborator Author

wutschel commented Feb 3, 2024

Yep. Was never looking into this yet. API response provides labels which could be used (same as are shown in the UI list). I guess it was done this way to limit the characters to be displayed. Same happens for the skip steps. It shows "-600, -300, ...", but the API also provides "-10 min" and "-5 min". But then the whole list would exceed the available space.

@kambala-decapitator
Copy link
Collaborator

ok, will merge this, but will keep the issue open

But then the whole list would exceed the available space.

options text can be comma-separated in a multiline label

@wutschel
Copy link
Collaborator Author

wutschel commented Feb 3, 2024

ok, will merge this, but will keep the issue open

But then the whole list would exceed the available space.

options text can be comma-separated in a multiline label

Sounds good. I will add some comments in the issue to state what is left open.

@kambala-decapitator kambala-decapitator merged commit bb982f6 into xbmc:master Feb 3, 2024
@wutschel wutschel deleted the improve_settings_array branch February 3, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants