Use sync-exec instead of execSync as exec fallback #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting "npm install copy-paste" currently raises the error:
[execsync v1.0.2] Attempting to compile native extensions.
[execSync v1.0.2]
Native code compile failed!!
This error arises with the dependency execSync and is addressed by
the author of execSync [1] who recommends replacing execSync by
sync-exec [2].
Here we replace execSync with sync-exec, and npm install will run
with no errors.
[1] [mgutz/execSync#38](mgutz/execSync#38)
[2] https://www.npmjs.com/package/sync-exec
|
This is my first pull request to somebody else's repo, please let me know if I did anything wrong :) |
|
I could use this, can it be merged please? |
|
Thank you. Sorry about the delay. Been busy. @stuharvey would like commit access? |
xavi-
added a commit
that referenced
this pull request
Nov 6, 2015
Use sync-exec instead of execSync as exec fallback
srn
referenced
this pull request
in srn/jlint
Nov 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting "npm install copy-paste" currently raises the error:
[execsync v1.0.2] Attempting to compile native extensions. [execSync v1.0.2] Native code compile failed!!This error arises with the dependency execSync and is addressed by
the author of execSync [1] who recommends replacing execSync by
sync-exec [2].
Here we replace execSync with sync-exec, and npm install will run
with no errors.
This fixes issue #33.
[1] mgutz/execSync#38
[2] https://www.npmjs.com/package/sync-exec