Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support placeholders in style config options. #154

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sigurdo
Copy link

@sigurdo sigurdo commented Jun 24, 2023

Also increases the version number to a new minor version, since there are new features that might something.

I used #104 for reference implementation.

Also increases the version number to a new minor version, since there are new features that might something.
@sigurdo
Copy link
Author

sigurdo commented Jun 26, 2023

I'm sorry that my message appeared very disrespectful, especially considering that I just started using this extension and am completely new to the project. I also have generally very little knowledge of developing vscode extensions.

However, in my case, I store my clang-format style in a file style.clang-format at a location clang-format is not able to detect automatically. I therefore have to configure "clang-format.style" in .vscode/settings.json as "file:/absolute/path/to/style.clang-format". I think it would make sense to commit this to the git repo, but then I would prefer writing "file:${workspaceFolder}/path/to/style.clang-format", so that works on other computers. This is what my PR aims to support.

If you think the code is unproperly written for the extension, I would love to get feedback and will see if I can improve it.

@TheAlbertDev
Copy link

This functionality is critical and it is very important that it is merged. Thank you @sigurdo 🙌🏻

@troyliu0105
Copy link

Is this project dead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants