Improve support for elasticsearch replication #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the support for elasticsearch replication, as well as improving the feature support for opensearch replication. Before this PR we were using a go-elasticsearch library version that supported opensearch (before it introduced version/client/server checks in 2021). This prevented any updates, and it had limitations when using vector fields with elasticsearch.
By separating the opensearch and elasticsearch clients we can address the slight differences for each in the index, mapping and overall library use. The separation is done at the library/pkg level, the rest of changes are meant to align with a decoupled approach, avoiding leaking implementation details.
Main changes:
knn_vector
vsdense_vector
) .The commits have been split for ease of reviewing.