Add subscriptions store cache #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an in memory cache layer to the webhook subscriptions store. It aims to be an ephemeral lightweight cache to minimise calls to the persistent store, since the subscriptions need to be retrieved on each WAL event received (this can be very frequent on data ingestion/deletion).
The cache can be configured to sync with the underlying store on a given interval, which will determine the staleness of the cache. In case of large numbers of subscriptions which are constantly updated, this wrapper will not be optimal and should not be used. It is disabled by default.