Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add opensearch mapper tests #15

Merged
merged 1 commit into from
May 20, 2024
Merged

Add opensearch mapper tests #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
290 changes: 290 additions & 0 deletions pkg/wal/processor/search/opensearch/opensearch_pg_mapper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,290 @@
// SPDX-License-Identifier: Apache-2.0

package opensearch

import (
"errors"
"fmt"
"testing"
"time"

"github.com/stretchr/testify/require"
"github.com/xataio/pgstream/pkg/schemalog"
"github.com/xataio/pgstream/pkg/wal/processor/search"
)

func TestMapper_ColumnToSearchMapping(t *testing.T) {
tests := map[string]struct {
pg string
columnMetadata *string
mapping map[string]any
}{
"int8": {
pg: "int8",
mapping: map[string]any{"type": "long"},
},
"bigint": {
pg: "bigint",
mapping: map[string]any{"type": "long"},
},
"int2[]": {
pg: "int2[]",
mapping: map[string]any{"type": "long"},
},
"integer": {
pg: "integer",
mapping: map[string]any{"type": "long"},
},
"float": {
pg: "float",
mapping: map[string]any{"type": "double"},
},
"float4[]": {
pg: "float4[]",
mapping: map[string]any{"type": "double"},
},
"numeric": {
pg: "numeric",
mapping: map[string]any{"type": "double"},
},
"numeric(5,2)": {
pg: "numeric(5,2)",
mapping: map[string]any{"type": "double"},
},
"numeric(100,2)[]": {
pg: "numeric(100,2)[]",
mapping: map[string]any{"type": "double"},
},
"boolean": {
pg: "boolean",
mapping: map[string]any{"type": "boolean"},
},
"boolean[]": {
pg: "boolean[]",
mapping: map[string]any{"type": "boolean"},
},
"bytea": {
pg: "bytea",
mapping: map[string]any{
"type": "keyword",
"ignore_above": termByteLengthLimit,
"fields": map[string]any{
"text": map[string]any{
"type": "text",
},
},
},
},
"text": {
pg: "text",
mapping: map[string]any{
"type": "keyword",
"ignore_above": termByteLengthLimit,
"fields": map[string]any{
"text": map[string]any{
"type": "text",
},
},
},
},
"text[]": {
pg: "text[]",
mapping: map[string]any{
"type": "keyword",
"ignore_above": termByteLengthLimit,
"fields": map[string]any{
"text": map[string]any{
"type": "text",
},
},
},
},
"varchar(100)[]": {
pg: "varchar(100)[]",
mapping: map[string]any{
"type": "keyword",
"ignore_above": termByteLengthLimit,
"fields": map[string]any{
"text": map[string]any{
"type": "text",
},
},
},
},
"time": {
pg: "time",
mapping: map[string]any{
"type": "date",
"format": "HH:mm:ss[.SS][x][Z]||HH:mm:ss[.SSS][x][Z]||HH:mm:ss[.SSSSSS][x][Z]",
},
},
"date": {
pg: "date",
mapping: map[string]any{
"type": "date",
"format": "date",
},
},
"timestamptz": {
pg: "timestamptz",
mapping: map[string]any{
"type": "date",
"format": "yyyy-MM-dd HH:mm:ss[.SSS][x]||yyyy-MM-dd HH:mm:ss[.SS][x]||yyyy-MM-dd HH:mm:ss[.S][x]||yyyy-MM-dd'T'HH:mm:ss[.SSS][X]",
},
},
"timestamp": {
pg: "timestamp",
mapping: map[string]any{
"type": "date",
"format": "yyyy-MM-dd HH:mm:ss[.SSS][x]||yyyy-MM-dd HH:mm:ss[.SS][x]||yyyy-MM-dd HH:mm:ss[.S][x]||yyyy-MM-dd'T'HH:mm:ss[.SSS][X]",
},
},
"timestamp with time zone[]": {
pg: "timestamp with time zone[]",
mapping: map[string]any{
"type": "date",
"format": "yyyy-MM-dd HH:mm:ss[.SSS][x]||yyyy-MM-dd HH:mm:ss[.SS][x]||yyyy-MM-dd HH:mm:ss[.S][x]||yyyy-MM-dd'T'HH:mm:ss[.SSS][X]",
},
},
"real[]": {
pg: "real[]",
mapping: map[string]any{"type": "double"},
},
"jsonb": {
pg: "jsonb",
mapping: map[string]any{"type": "text"},
},
"json": {
pg: "json",
mapping: map[string]any{"type": "text"},
},
"macaddr": {
pg: "macaddr",
mapping: map[string]any{
"type": "keyword",
"ignore_above": termByteLengthLimit,
"fields": map[string]any{
"text": map[string]any{
"type": "text",
},
},
},
},
}

for name, test := range tests {
t.Run(name, func(t *testing.T) {
m := NewPostgresMapper()
mapping, err := m.ColumnToSearchMapping(schemalog.Column{
DataType: test.pg,
Metadata: test.columnMetadata,
})
require.NoError(t, err)
require.Equal(t, test.mapping, mapping)
})
}

errorTests := map[string]struct {
pg string
}{
"invalid type": {
pg: "a",
},
"badly formatted parameters": {
pg: "numeric)[]",
},
}

for name, test := range errorTests {
t.Run(name, func(t *testing.T) {
m := NewPostgresMapper()
_, err := m.ColumnToSearchMapping(schemalog.Column{DataType: test.pg})
require.Error(t, err)

var k search.ErrTypeInvalid
require.True(t, errors.As(err, &k))
})
}
}

func TestMapper_MapColumnValue(t *testing.T) {
t.Parallel()

now := time.Now()
tsNow := now.Truncate(time.Millisecond).Format(timestampFormat)
tstzNow := now.Truncate(time.Millisecond).Format(timestampTZFormat)
const pgFormatTz = "2006-01-02 15:04:05.000000+00"
const pgFormat = "2006-01-02 15:04:05.000000"

tests := []struct {
name string
column schemalog.Column
value any

wantValue any
wantErr error
}{
{
name: "date",
column: schemalog.Column{DataType: "date"},
value: "2024-03-12",

wantValue: "2024-03-12",
wantErr: nil,
},
{
name: "timestamp",
column: schemalog.Column{DataType: "timestamp"},
value: now,

wantValue: tsNow,
wantErr: nil,
},
{
name: "timestamp with time zone",
column: schemalog.Column{DataType: "timestamptz"},
value: now,

wantValue: tstzNow,
wantErr: nil,
},
{
name: "timestamp with time zone array",
column: schemalog.Column{DataType: "timestamptz[]"},
value: fmt.Sprintf("{%q}", now.Format(pgFormatTz)),

wantValue: []string{tstzNow},
wantErr: nil,
},
{
name: "timestamp array",
column: schemalog.Column{DataType: "timestamp[]"},
value: fmt.Sprintf("{%q}", now.Format(pgFormat)),

wantValue: []string{tsNow},
wantErr: nil,
},
{
name: "unknonwn column type",
column: schemalog.Column{DataType: "custom_type"},
value: "value",

wantValue: nil,
wantErr: errors.New("mapping column from pg to os: unsupported type: custom_type"),
},
}

for _, tc := range tests {
tc := tc
t.Run(tc.name, func(t *testing.T) {
t.Parallel()

mapper := NewPostgresMapper()
value, err := mapper.MapColumnValue(tc.column, tc.value)
if !errors.Is(err, tc.wantErr) {
require.Error(t, err, tc.wantErr.Error())
}
require.Equal(t, tc.wantValue, value)
})
}
}