CLI: Allow binaries to autoupdate #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9b2b2e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Your pull request has been published to npm. You can install @xata.io/client by running: Other packages are published like this: To test the CLI, run: |
size-limit report 📦
|
eemmiillyy
force-pushed
the
feat/cli-autoupdates
branch
from
867b5b3
to
72b406c
Compare
eemmiillyy
force-pushed
the
feat/cli-autoupdates
branch
from
472f1dc
to
da2760f
Compare
SferaDev
reviewed
Jul 19, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SferaDev
reviewed
Jul 25, 2024
cli/package.json
Outdated
Comment on lines
21
to
23
| "engines": { | ||
| "node": ">=8" | ||
| }, |
There was a problem hiding this comment.
Not sure why we need this, also the version looks odd
There was a problem hiding this comment.
We need it because oclif throws an error if it is undefined: https://github.com/oclif/oclif/blob/main/src/tarballs/build.ts#L258
There was a problem hiding this comment.
What version should it be instead?
SferaDev
approved these changes
Jul 25, 2024
Co-authored-by: Alexis Rico <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.