Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Web URL to response when comparing in a repository #2055

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

heidiberry
Copy link
Contributor

Fixes #2031

repositories.go Outdated
@@ -209,6 +209,7 @@ type Compare struct {
Diffs []*Diff `json:"diffs"`
CompareTimeout bool `json:"compare_timeout"`
CompareSameRef bool `json:"compare_same_ref"`
WebUrl string `json:"web_url"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read: https://go.dev/wiki/CodeReviewComments#initialisms In Go this field should be named WebURL

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏻

@svanharmelen svanharmelen merged commit 5548b4f into xanzy:main Nov 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repositories API Compare call is missing WebURL
2 participants