feat: add deployment approval config attribute #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `allow_pipeline_trigger_approve_deployment` attribute exists on the Project entity and is returned in the Get Project API[1] even though it is not documented. [1]: https://docs.gitlab.com/ee/api/projects.html#get-a-single-project
|
Apart from the diffs in the original GitLab issue that implemented this change, I also wanted to provide screenshots that this attribute indeed exists on the entity itself. When retrieving a single GitLab project, we can observe that this attribute is returned: 
I have created a separate ticket in GitLab to update the documentation: https://gitlab.com/gitlab-org/gitlab/-/issues/497730. |
svanharmelen
approved these changes
Oct 4, 2024
|
@svanharmelen Thank you, I appreciate it! I will also report back once GitLab Docs are updated as well, just to close the loop. |
loozhengyuan
deleted the
feat/add-allow-pipeline-trigger-approve-deployment
branch
|
@svanharmelen Just to close the loop: the updates to GitLab docs have been merged in, thanks! |
|
Thanks for closing the loop! 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
allow_pipeline_trigger_approve_deploymentattribute exists on the Project entity and is returned in the Get Project API1 even though it is not documented.Related: #1693