Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update / Complete test cases #1726

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Conversation

mgross-ebner
Copy link
Contributor

@mgross-ebner mgross-ebner commented May 31, 2023

To avoid bugs due to incomplete test data, this pull request completes the test cases with missing ("null") values. Before I process all other events, please give me your basic agreement.

Documentation

@svanharmelen
Copy link
Member

I'm fine with this, as long as the values that are used are double checked with the API. So in case they are not shown in the docs, I prefer pointers to the GitLab codebase or (as second best) the output of an actual API call showing the returned values.

Thanks!

@mgross-ebner
Copy link
Contributor Author

Ok, but can we agree that the proof is per field not per field and file?

@svanharmelen
Copy link
Member

I guess in most (if not all) cases we can...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants