build: add support for analytics secret key

Signed-off-by: Akshay "XA" Mestry <[email protected]>
xames3 · Mar 2, 2024 · e8e60e8 · e8e60e8
1 parent 0900ed6
commit e8e60e8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.github/workflows/publish-pages.yaml b/.github/workflows/publish-pages.yaml
@@ -56,11 +56,11 @@ jobs:
         run: |
           python -m pip install --upgrade pip
           pip install -r requirements.txt
+        env:
+          GOOGLE_ANALYTICS_ID: ${{ secrets.GOOGLE_ANALYTICS_ID }}
 
       - name: Build Sphinx documentation pages
         run: sphinx-build -EWaq -b html ${{ env.SOURCE_DIR }} ${{ env.OUTPUT_DIR }}
-        env:
-          GOOGLE_ANALYTICS_ID: ${{ secrets.GOOGLE_ANALYTICS_ID }}
 
       - name: Publish L.E.A.R.N's static files to GitHub Pages
         uses: peaceiris/actions-gh-pages@v3

diff --git a/docs/source/conf.py b/docs/source/conf.py
@@ -341,9 +341,7 @@ class LearnProject(t.NamedTuple):
 html_title = _project.short_title
 html_theme_options = {
     "analytics": {
-        "google_analytics_id": os.environ.get(
-            "GOOGLE_ANALYTICS_ID", "G-XXXXXXXXXX"
-        )
+        "google_analytics_id": os.environ.get("GOOGLE_ANALYTICS_ID", "")
     },
     "article_header_end": [],
     "footer_center": ["theme-version"],