[Rgen] Simplify the way we execute tests on all platforms. (#21547)

There is no need to write a line per platform when we can use an attribvute for that. --------- Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
xamarin · Oct 30, 2024 · 524279f · 524279f
1 parent cf03595
commit 524279f
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 40 deletions.
diff --git a/tests/common/ConfigurationXUnit.cs b/tests/common/ConfigurationXUnit.cs
@@ -47,11 +47,38 @@ public override IEnumerable<object []> GetData (MethodInfo testMethod)
 		}
 	}
 
+	[AttributeUsage (AttributeTargets.Method, AllowMultiple = true, Inherited = true)]
+	public sealed class AllSupportedPlatformsAttribute : DataAttribute {
+
+		readonly object [] dataValues;
+
+		public AllSupportedPlatformsAttribute (params object [] parameters)
+		{
+			dataValues = parameters;
+		}
+
+		public override IEnumerable<object []> GetData (MethodInfo testMethod)
+		{
+			return Configuration.
+				GetIncludedPlatforms (true).
+				Select (platform => dataValues.Prepend (platform).ToArray ());
+		}
+	}
+
 	public partial class Configuration {
 		static string TestAssemblyDirectory {
 			get {
 				return Assembly.GetExecutingAssembly ().Location;
 			}
 		}
+
+		public static bool IsEnabled (ApplePlatform platform)
+			=> platform switch {
+				ApplePlatform.iOS => include_ios,
+				ApplePlatform.TVOS => include_tvos,
+				ApplePlatform.MacCatalyst => include_maccatalyst,
+				ApplePlatform.MacOSX => include_mac,
+				_ => false
+			};
 	}
 }
diff --git a/tests/rgen/Microsoft.Macios.Generator.Tests/BindingSourceGeneratorGeneratorTests.cs b/tests/rgen/Microsoft.Macios.Generator.Tests/BindingSourceGeneratorGeneratorTests.cs
@@ -37,10 +37,7 @@ public partial class AVAudioPcmBuffer
 ";
 
 	[Theory]
-	[PlatformInlineData (ApplePlatform.iOS, usingImportInput, usingImportOutput)]
-	[PlatformInlineData (ApplePlatform.TVOS, usingImportInput, usingImportOutput)]
-	[PlatformInlineData (ApplePlatform.MacOSX, usingImportInput, usingImportOutput)]
-	[PlatformInlineData (ApplePlatform.MacCatalyst, usingImportInput, usingImportOutput)]
+	[AllSupportedPlatforms (usingImportInput, usingImportOutput)]
 	public void CorrectUsingImports (ApplePlatform platform, string input, string expectedOutput)
 	{
 		// We need to create a compilation with the required source code.

diff --git a/...n/Microsoft.Macios.Generator.Tests/Extensions/BaseTypeDeclarationSyntaxExtensionsTests.cs b/...n/Microsoft.Macios.Generator.Tests/Extensions/BaseTypeDeclarationSyntaxExtensionsTests.cs
@@ -24,10 +24,7 @@ T GetDeclaration<T> (ApplePlatform platform, string inputText) where T : BaseTyp
 	}
 
 	[Theory]
-	[PlatformInlineData (ApplePlatform.iOS)]
-	[PlatformInlineData (ApplePlatform.TVOS)]
-	[PlatformInlineData (ApplePlatform.MacCatalyst)]
-	[PlatformInlineData (ApplePlatform.MacOSX)]
+	[AllSupportedPlatforms]
 	public void GetFullyQualifiedIdentifierFileScopedNamespace (ApplePlatform platform)
 	{
 		const string inputText = @"
@@ -40,10 +37,7 @@ public class Foo {
 	}
 
 	[Theory]
-	[PlatformInlineData (ApplePlatform.iOS)]
-	[PlatformInlineData (ApplePlatform.TVOS)]
-	[PlatformInlineData (ApplePlatform.MacCatalyst)]
-	[PlatformInlineData (ApplePlatform.MacOSX)]
+	[AllSupportedPlatforms]
 	public void GetFullyQualifiedIdentifierFileScopedNamespaceNestedClass (ApplePlatform platform)
 	{
 		const string inputText = @"
@@ -58,10 +52,7 @@ public enum Bar {
 	}
 
 	[Theory]
-	[PlatformInlineData (ApplePlatform.iOS)]
-	[PlatformInlineData (ApplePlatform.TVOS)]
-	[PlatformInlineData (ApplePlatform.MacCatalyst)]
-	[PlatformInlineData (ApplePlatform.MacOSX)]
+	[AllSupportedPlatforms]
 	public void GetFullyQualifiedIdentifierNamespaceDeclaration (ApplePlatform platform)
 	{
 		const string inputText = @"
@@ -75,10 +66,7 @@ public class Foo {
 	}
 
 	[Theory]
-	[PlatformInlineData (ApplePlatform.iOS)]
-	[PlatformInlineData (ApplePlatform.TVOS)]
-	[PlatformInlineData (ApplePlatform.MacCatalyst)]
-	[PlatformInlineData (ApplePlatform.MacOSX)]
+	[AllSupportedPlatforms]
 	public void GetFullyQualifiedIdentifierMultipleNamespaceDeclaration (ApplePlatform platform)
 	{
 		const string inputText = @"
@@ -94,10 +82,7 @@ public class Bar {}
 	}
 
 	[Theory]
-	[PlatformInlineData (ApplePlatform.iOS)]
-	[PlatformInlineData (ApplePlatform.TVOS)]
-	[PlatformInlineData (ApplePlatform.MacCatalyst)]
-	[PlatformInlineData (ApplePlatform.MacOSX)]
+	[AllSupportedPlatforms]
 	public void GetFullyQualifiedIdentifierNestedNamespaceDeclaration (ApplePlatform platform)
 	{
 		const string inputText = @"
@@ -112,10 +97,7 @@ public class Test {}
 	}
 
 	[Theory]
-	[PlatformInlineData (ApplePlatform.iOS)]
-	[PlatformInlineData (ApplePlatform.TVOS)]
-	[PlatformInlineData (ApplePlatform.MacCatalyst)]
-	[PlatformInlineData (ApplePlatform.MacOSX)]
+	[AllSupportedPlatforms]
 	public void GetFullyQualifiedIdentifierNamespaceDeclarationNestedClass (ApplePlatform platform)
 	{
 		const string inputText = @"

diff --git a/...gen/Microsoft.Macios.Generator.Tests/Extensions/MemberDeclarationSyntaxExtensionsTests.cs b/...gen/Microsoft.Macios.Generator.Tests/Extensions/MemberDeclarationSyntaxExtensionsTests.cs
@@ -9,10 +9,7 @@ namespace Microsoft.Macios.Generator.Tests.Extensions;
 
 public class MemberDeclarationSyntaxExtensionsTests : BaseGeneratorTestClass {
 	[Theory]
-	[PlatformInlineData (ApplePlatform.iOS)]
-	[PlatformInlineData (ApplePlatform.TVOS)]
-	[PlatformInlineData (ApplePlatform.MacOSX)]
-	[PlatformInlineData (ApplePlatform.MacCatalyst)]
+	[AllSupportedPlatforms]
 	public void GetAttributeCodeChanges (ApplePlatform platform)
 	{
 		var attrsText = @"
@@ -99,10 +96,7 @@ public interface IInterface {
 	}
 
 	[Theory]
-	[PlatformInlineData (ApplePlatform.iOS)]
-	[PlatformInlineData (ApplePlatform.TVOS)]
-	[PlatformInlineData (ApplePlatform.MacOSX)]
-	[PlatformInlineData (ApplePlatform.MacCatalyst)]
+	[AllSupportedPlatforms]
 	public void GetAttributeCodeChangesSameAttrDiffText (ApplePlatform platform)
 	{
 		const string inputText = @"
@@ -144,10 +138,7 @@ public void SayGoodbye () {
 	}
 
 	[Theory]
-	[PlatformInlineData (ApplePlatform.iOS)]
-	[PlatformInlineData (ApplePlatform.TVOS)]
-	[PlatformInlineData (ApplePlatform.MacOSX)]
-	[PlatformInlineData (ApplePlatform.MacCatalyst)]
+	[AllSupportedPlatforms]
 	public void GetAttributeCodeChangesTypeOf (ApplePlatform platform)
 	{