Skip to content

Commit

Permalink
Select filter fix (#196)
Browse files Browse the repository at this point in the history 
* fix(filters): fix event type for the select filter so it can work on IE11

* add bundle
  • Loading branch information
@Idan747 @xaksis
Idan747 authored and xaksis committed Mar 6, 2018
1 parent 4be7fda commit c2f4cc5
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 15 deletions.
2 changes: 1 addition & 1 deletion dist/stats.json
View file

Large diffs are not rendered by default.

29 changes: 18 additions & 11 deletions dist/vue-good-table.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ function startOfISOWeek (dirtyDate, dirtyOptions) {
/* 4 */
/***/ (function(module, exports) {

var core = module.exports = { version: '2.5.1' };
var core = module.exports = { version: '2.5.3' };
if (typeof __e == 'number') __e = core; // eslint-disable-line no-undef


Expand Down Expand Up @@ -3495,7 +3495,7 @@ module.exports = function (Base, NAME, Constructor, next, DEFAULT, IS_SET, FORCE
var VALUES_BUG = false;
var proto = Base.prototype;
var $native = proto[ITERATOR] || proto[FF_ITERATOR] || DEFAULT && proto[DEFAULT];
var $default = $native || getMethod(DEFAULT);
var $default = (!BUGGY && $native) || getMethod(DEFAULT);
var $entries = DEFAULT ? !DEF_VALUES ? $default : getMethod('entries') : undefined;
var $anyNative = NAME == 'Array' ? proto.entries || $native : $native;
var methods, key, IteratorPrototype;
Expand Down Expand Up @@ -5524,14 +5524,18 @@ var singletonElement = null
var singletonCounter = 0
var isProduction = false
var noop = function () {}
var options = null
var ssrIdKey = 'data-vue-ssr-id'

// Force single-tag solution on IE6-9, which has a hard limit on the # of <style>
// tags it will allow on a page
var isOldIE = typeof navigator !== 'undefined' && /msie [6-9]\b/.test(navigator.userAgent.toLowerCase())

module.exports = function (parentId, list, _isProduction) {
module.exports = function (parentId, list, _isProduction, _options) {
isProduction = _isProduction

options = _options || {}

var styles = listToStyles(parentId, list)
addStylesToDom(styles)

Expand Down Expand Up @@ -5595,7 +5599,7 @@ function createStyleElement () {

function addStyle (obj /* StyleObjectPart */) {
var update, remove
var styleElement = document.querySelector('style[data-vue-ssr-id~="' + obj.id + '"]')
var styleElement = document.querySelector('style[' + ssrIdKey + '~="' + obj.id + '"]')

if (styleElement) {
if (isProduction) {
Expand Down Expand Up @@ -5677,6 +5681,9 @@ function applyToTag (styleElement, obj) {
if (media) {
styleElement.setAttribute('media', media)
}
if (options.ssrId) {
styleElement.setAttribute(ssrIdKey, obj.id)
}

if (sourceMap) {
// https://developer.chrome.com/devtools/docs/javascript-debugging
Expand Down Expand Up @@ -14668,7 +14675,7 @@ var Component = __webpack_require__(84)(
/* moduleIdentifier (server only) */
null
)
Component.options.__file = "/Users/akshay/Projects/learn/vue/plugins/vue-good-table/src/components/Pagination.vue"
Component.options.__file = "/home/codeoasis/forks/vue-good-table/src/components/Pagination.vue"
if (Component.esModule && Object.keys(Component.esModule).some(function (key) {return key !== "default" && key.substr(0, 2) !== "__"})) {console.error("named exports are not supported in *.vue files.")}
if (Component.options.functional) {console.error("[vue-loader] Pagination.vue: functional components are not supported with templates, they should use render functions.")}

Expand Down Expand Up @@ -14712,7 +14719,7 @@ var Component = __webpack_require__(84)(
/* moduleIdentifier (server only) */
null
)
Component.options.__file = "/Users/akshay/Projects/learn/vue/plugins/vue-good-table/src/components/Table.vue"
Component.options.__file = "/home/codeoasis/forks/vue-good-table/src/components/Table.vue"
if (Component.esModule && Object.keys(Component.esModule).some(function (key) {return key !== "default" && key.substr(0, 2) !== "__"})) {console.error("named exports are not supported in *.vue files.")}
if (Component.options.functional) {console.error("[vue-loader] Table.vue: functional components are not supported with templates, they should use render functions.")}

Expand Down Expand Up @@ -14862,7 +14869,7 @@ module.exports={render:function (){var _vm=this;var _h=_vm.$createElement;var _c
}
}, [_c('div', {
staticClass: "global-search"
}, [_vm._m(0, false, false), _vm._v(" "), _c('input', {
}, [_vm._m(0), _vm._v(" "), _c('input', {
directives: [{
name: "model",
rawName: "v-model",
Expand Down Expand Up @@ -14927,7 +14934,7 @@ module.exports={render:function (){var _vm=this;var _h=_vm.$createElement;var _c
"value": _vm.columnFilters[column.field]
},
on: {
"input": function($event) {
"change": function($event) {
_vm.updateFilters(column, $event.target.value)
}
}
Expand All @@ -14948,7 +14955,7 @@ module.exports={render:function (){var _vm=this;var _h=_vm.$createElement;var _c
"value": _vm.columnFilters[column.field]
},
on: {
"input": function($event) {
"change": function($event) {
_vm.updateFilters(column, $event.target.value)
}
}
Expand Down Expand Up @@ -15045,7 +15052,7 @@ var content = __webpack_require__(130);
if(typeof content === 'string') content = [[module.i, content, '']];
if(content.locals) module.exports = content.locals;
// add the styles to the DOM
var update = __webpack_require__(85)("219bb374", content, false);
var update = __webpack_require__(85)("1587db6c", content, false, {});
// Hot Module Replacement
if(false) {
// When the styles change, update the <style> tags
Expand All @@ -15071,7 +15078,7 @@ var content = __webpack_require__(131);
if(typeof content === 'string') content = [[module.i, content, '']];
if(content.locals) module.exports = content.locals;
// add the styles to the DOM
var update = __webpack_require__(85)("4dfb852a", content, false);
var update = __webpack_require__(85)("7993fc22", content, false, {});
// Hot Module Replacement
if(false) {
// When the styles change, update the <style> tags
Expand Down
2 changes: 1 addition & 1 deletion dist/vue-good-table.min.js
View file

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/components/Table.vue
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
<select v-if="column.filterDropdown && typeof(column.filterOptions[0]) !== 'object'"
class=""
:value="columnFilters[column.field]"
v-on:input="updateFilters(column, $event.target.value)">
v-on:change="updateFilters(column, $event.target.value)">
<option value="" key="-1">{{ getPlaceholder(column) }}</option>
<option
v-for="(option, i) in column.filterOptions"
Expand All @@ -80,7 +80,7 @@
<select v-if="column.filterDropdown && typeof(column.filterOptions[0]) === 'object'"
class=""
:value="columnFilters[column.field]"
v-on:input="updateFilters(column, $event.target.value)">
v-on:change="updateFilters(column, $event.target.value)">
<option value="" key="-1">{{ getPlaceholder(column) }}</option>
<option
v-for="(option, i) in column.filterOptions"
Expand Down

0 comments on commit c2f4cc5

Please sign in to comment.