Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update semantic-release job to utilize bash instead of js #585

Merged

Conversation

krishnanand5
Copy link
Collaborator

Pull Request

Description

This PR updates the implementation of the semantic-release job in release action from JS to bash

Related Issues

The retry mechanism to prevent the rate-limiting issue is yet to verified but this PR addresses the issues with JS by replacing it with its bash equivalent

Changes Made

Javascript execution with the exec module in git actions is being problematic owing to ambiguities in access and unavailability of exec module. To address this, the job has been migrated to a dependency-free bash equivalent. The bash script takes care of running the specified yarn command at pre-defined time intervals.

Checklist

  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code and ensured it follows the project's coding standards.
  • I have tested the changes locally following ManualTestingProcess.md, and all tests related to this pull request pass.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if applicable.
  • I have added appropriate unit tests, if applicable.

@jooyoungseo jooyoungseo merged commit 89ce7db into xability:main Oct 17, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
## [2.19.1](v2.19.0...v2.19.1) (2024-10-17)

### Bug Fixes

* address failure in release action ([#583](#583)) ([64b90f4](64b90f4))
* address failure in release action ([#584](#584)) ([992a18a](992a18a))
* barplot autoplay left ([#582](#582)) ([749da16](749da16))
* include retry logic for semantic-release job ([#577](#577)) ([5c67114](5c67114))
* update semantic-release job to utilize bash instead of js ([#585](#585)) ([89ce7db](89ce7db))
Copy link
Contributor

🎉 This PR is included in version 2.19.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants