Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(heatmap): kill visual selector and autoplay post maidr teardown #534

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(heatmap): kill visual selector and autoplay post maidr teardown #534

merged 1 commit into from
Aug 28, 2024

Conversation

krishnanand5
Copy link
Collaborator

@krishnanand5 krishnanand5 commented Aug 28, 2024 •
edited
Loading

Pull Request

Description

This Pull request contains changes to remove the visual element selector and cease autoplay when maidr is deactivated.

Related Issues

Closes #533

Changes Made

As per the current teardown logic in DestroyChartComponents() of src/js/init.js, we are handling the autoplay termination and visual element selector removal for Line plots and Scatterplots. The same has been extended to heatmap based on its configuration.

The visual element selector will be removed along with termination of autoplay on heatmap going forward. This brings the plot back to its original state and prevents maidr from autonomously running autoplay during maidr reactivation.

Checklist

  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code and ensured it follows the project's coding standards.
  • I have tested the changes locally following ManualTestingProcess.md, and all tests related to this pull request pass.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if applicable.
  • I have added appropriate unit tests, if applicable.

Additional Notes

Closes #533

jooyoungseo
jooyoungseo approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@jooyoungseo jooyoungseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jooyoungseo jooyoungseo merged commit 17c286d into xability:main Aug 28, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Aug 29, 2024
@semantic-release-bot
chore(release): 2.14.7 [skip ci]
e28d9f7 
## [2.14.7](v2.14.6...v2.14.7) (2024-08-29)

### Bug Fixes

* **ci:** rectify formatting in affected file for build workflow ([#536](#536)) ([03ed380](03ed380))
* **heatmap:** kill visual selector and autoplay post maidr teardown ([#534](#534)) ([17c286d](17c286d))
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 2.14.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jooyoungseo jooyoungseo jooyoungseo approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix (heatmap): maidr remnants post teardown and ghost autoplay observed
2 participants
@krishnanand5 @jooyoungseo