Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lineplot): support graceful failure #430

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

SaaiVenkat
Copy link
Collaborator

Pull Request

Description

Without the selector, the lineplot's BTS mode don't work properly.

Related Issues

Closes #429

Changes Made

If the selector is not available, used the raw data to navigate through the lineplot

Screenshots (if applicable)

Checklist

  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code and ensured it follows the project's coding standards.
  • I have tested the changes locally following ManualTestingProcess.md, and all tests related to this pull request pass.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if applicable.
  • I have added appropriate unit tests, if applicable.

Additional Notes

@SaaiVenkat SaaiVenkat requested review from ellvix and jooyoungseo March 6, 2024 16:07
@jooyoungseo
Copy link
Member

@SaaiVenkat Please feel free to merge once ready.

@SaaiVenkat SaaiVenkat merged commit 1f117c3 into xability:main Mar 20, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
## [2.5.1](v2.5.0...v2.5.1) (2024-03-21)

### Bug Fixes

* **lineplot:** support graceful failure ([#430](#430)) ([1f117c3](1f117c3))
Copy link
Contributor

🎉 This PR is included in version 2.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: lineplot graceful failure
2 participants